Add notify to server options & also_notify to server and zone options. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request adds more complete notification options to both zones and the server options. In both cases, `zone_notify` sets the BIND "notify" option (which can be one of *on*, *off*, *master-only*, or *explicit*), and `also_notify` is a list of ip addresses of name servers that will be sent notifications in addition to the zone's nameservers. Both zone_notify and also_notify are validated in dns::server::options and dns::zone, and new tests are added to dns__server__options_spec.rb and dns__zone_spec.rb to test the individual values for each parameter.
|
Looks great! |
solarkennedy
added a commit
that referenced
this pull request
May 6, 2015
Add notify to server options & also_notify to server and zone options.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds more complete notification options to both zones
and the server options. In both cases,
zone_notifysets the BIND"notify" option (which can be one of on, off, master-only, or
explicit), and
also_notifyis a list of ip addresses of name serversthat will be sent notifications in addition to the zone's nameservers.
Both zone_notify and also_notify are validated in dns::server::options
and dns::zone, and new tests are added to dns__server__options_spec.rb
and dns__zone_spec.rb to test the individual values for each parameter.